Skip to content

Enforcing use of the safe macro when logging #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

bergel
Copy link
Collaborator

@bergel bergel commented Oct 11, 2024

No description provided.

Copy link

github-actions bot commented Oct 11, 2024

Static code analyzer report

Output of the StaticLint.jl code analyzer. 🫵Want to contribute?🫵 RelationalAI Style Guide for Julia
Report creation time (UTC): (2024-10-15T08:41:45.882)

  • Line 58, column 43: Use $(x) instead of $x (explanation). raicode/src/linting/extended_checks.jl
  • Line 272, column 5: Use tin(item,collection) instead of the Julia's in or . raicode/src/linting/extended_checks.jl
  • Line 316, column 13: Use tin(item,collection) instead of the Julia's in or . raicode/src/linting/extended_checks.jl
  • Line 348, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 402, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 405, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 406, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 446, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 543, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 555, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 31, column 16: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 43, column 16: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 1028, column 41: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 1084, column 41: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 1145, column 41: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 1328, column 21: Unsafe logging statement. You must enclose variables and strings with @safe(...). raicode/test/rai_rules_tests.jl
  • Line 327, column 23: Use tin(item,collection) instead of the Julia's in or . raicode/test/static_lint_tests.jl
  • Line 671, column 27: Use tin(item,collection) instead of the Julia's in or . raicode/test/static_lint_tests.jl
  • Line 675, column 23: Use tin(item,collection) instead of the Julia's in or . raicode/test/static_lint_tests.jl
  • Line 1121, column 23: Use thaskey(dict,key) instead of the Julia's haskey. raicode/test/static_lint_tests.jl
  • Line 1133, column 24: Use thaskey(dict,key) instead of the Julia's haskey. raicode/test/static_lint_tests.jl
  • Line 1150, column 20: Use thaskey(dict,key) instead of the Julia's haskey. raicode/test/static_lint_tests.jl
  • Line 1161, column 20: Use thaskey(dict,key) instead of the Julia's haskey. raicode/test/static_lint_tests.jl
  • Line 1336, column 15: Use thaskey(dict,key) instead of the Julia's haskey. raicode/test/static_lint_tests.jl
  • Line 1513, column 11: Use thaskey(dict,key) instead of the Julia's haskey. raicode/test/static_lint_tests.jl
  • Line 1514, column 11: Use thaskey(dict,key) instead of the Julia's haskey. raicode/test/static_lint_tests.jl
  • Line 1715, column 12: Use thaskey(dict,key) instead of the Julia's haskey. raicode/test/static_lint_tests.jl
  • Line 1716, column 11: Use thaskey(dict,key) instead of the Julia's haskey. raicode/test/static_lint_tests.jl
    🚨In total, 28 rule violations and 0 PR reviewer recommendation are found over 3 Julia files🚨

@bergel bergel merged commit eaea891 into main Oct 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant